[sonic-package-manager] support sonic-cli-gen and packages with YANG model #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
…packages-migration
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
…packages-migration Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Co-authored-by: Joe LeVeque <jleveque@users.noreply.github.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
|
@praveen-li Could you please also review? |
There was a problem hiding this comment.
Looks good to me. Just added few minor comments only.
We could merge upon approval by @praveen-li
|
@praveen-li , @renukamanavalan - do you approve this PR or anything pending? Thanks. |
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
|
This pull request introduces 1 alert when merging bf05d42 into e7535ae - view on LGTM.com new alerts:
|
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
|
@renukamanavalan - completed review -- good to merge |
renukamanavalan
approved these changes
Nov 20, 2021
praveen-li
approved these changes
Nov 24, 2021
| module_name = self.get_module_name(yang_module_str) | ||
| module_path = os.path.join(YANG_DIR, '{}.yang'.format(module_name)) | ||
| if os.path.exists(module_path): | ||
| raise Exception('{} already exists'.format(module_name)) |
There was a problem hiding this comment.
caller of add_module should be able to handle it gracefully.
There was a problem hiding this comment.
The caller can catch the exception and handle it gracefully.
5 tasks
Closed
5 tasks
abdosi
pushed a commit
that referenced
this pull request
Dec 8, 2021
…model (#1650) - What I did This PR brings in support for packages with YANG models and CLI auto generation capabilities for 3rd party packages. - How I did it Packages can set two new flags in manifest - "auto-generate-show" and "auto-generate-config" in addition to YANG module recorded in package image label "com.azure.sonic.yang-module". - How to verify it Build and run. Prepare some package with YANG model and test CLI is generated for it. Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com> Co-authored-by: Vadym Hlushko <vadymh@nvidia.com>
prgeor
added a commit
to prgeor/sonic-utilities
that referenced
this pull request
Dec 16, 2021
…th YANG model (sonic-net#1650)" This reverts commit f5e5a56.
stepanblyschak
added a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Dec 30, 2021
…kages with YANG model (sonic-net#1650)" (sonic-net#1972)" This reverts commit fe00bbf.
DavidZagury
added a commit
to DavidZagury/sonic-utilities
that referenced
this pull request
Jan 12, 2022
…kages with YANG model (sonic-net#1650)" (sonic-net#1972)" This reverts commit fe00bbf.
liat-grozovik
pushed a commit
that referenced
this pull request
Jan 17, 2022
…kages with YANG model (#1650)" (#1972)" (#1994) This reverts commit fe00bbf. - What I did Revert previous revert, since the proposed fix has been merged - sonic-net/sonic-buildimage#9587 - How I did it Revert the revert. - How to verify it Run build an on the switch.
judyjoseph
pushed a commit
that referenced
this pull request
Jan 31, 2022
…kages with YANG model (#1650)" (#1972)" (#1994) This reverts commit fe00bbf. - What I did Revert previous revert, since the proposed fix has been merged - sonic-net/sonic-buildimage#9587 - How I did it Revert the revert. - How to verify it Run build an on the switch.
dbarashinvd
pushed a commit
to dbarashinvd/sonic-utilities
that referenced
this pull request
Jul 11, 2022
…kages with YANG model (sonic-net#1650)" (sonic-net#1972)" (sonic-net#1994) This reverts commit fe00bbf. - What I did Revert previous revert, since the proposed fix has been merged - sonic-net/sonic-buildimage#9587 - How I did it Revert the revert. - How to verify it Run build an on the switch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: DEPENDS ON #1644
What I did
This PR brings in support for packages with YANG models and CLI auto generation capabilities for 3rd party packages.
How I did it
Packages can set two new flags in manifest - "auto-generate-show" and "auto-generate-config" in addition to YANG module recorded in package image label "com.azure.sonic.yang-module".
How to verify it
Build and run. Prepare some package with YANG model and test CLI is generated for it.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)